Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some unexpected behavior in @add implementation #104

Open
egregors opened this issue Mar 18, 2020 · 0 comments
Open

Some unexpected behavior in @add implementation #104

egregors opened this issue Mar 18, 2020 · 0 comments
Labels
bug Something isn't working core help wanted Extra attention is needed

Comments

@egregors
Copy link
Collaborator

@add wrapper eval internal custom function for adding internal mode command handlers.

Next, @add should add mode commands, such a: foo_on, foo_off, foo (for the mode called "foo').

And next, if the default state of mode is False internal mode command handlers will be removed.

BUT! For some reason, if _remove_mode_handlers was not be called, the mode commands will not be work.

What a mess!

@egregors egregors added bug Something isn't working help wanted Extra attention is needed core labels Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant