Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import moment #514

Closed
timrasche opened this issue Aug 1, 2020 · 9 comments
Closed

Import moment #514

timrasche opened this issue Aug 1, 2020 · 9 comments

Comments

@timrasche
Copy link

Warning: Entry point 'ng2-date-picker' contains deep imports into 'node_modules/moment/moment'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

compiling 'hangs' sometimes and i'm think this is the problem.

@vlio20
Copy link
Owner

vlio20 commented Aug 1, 2020

@timrasche can you point where do you see this deep imports?

@timrasche
Copy link
Author

Of course, first line of output by angular/cli with

  • ng serve
  • ng build

@vlio20
Copy link
Owner

vlio20 commented Aug 1, 2020

I think I found the reason - working on a fix

@timrasche
Copy link
Author

you're the man! big thanks!

@vlio20
Copy link
Owner

vlio20 commented Aug 2, 2020

resolved in abe1cfb

@vlio20 vlio20 closed this as completed Aug 2, 2020
@vlio20
Copy link
Owner

vlio20 commented Aug 3, 2020

@timrasche can you please update to 10.0.0-rc.1 and see if you still see the issue?

@timrasche
Copy link
Author

@timrasche can you please update to 10.0.0-rc.1 and see if you still see the issue?

The warning by the angular/cli is gone. Thank you very much for the fast fix

@vlio20
Copy link
Owner

vlio20 commented Aug 3, 2020

Cool so it will be available later today in 10.0.0.
Your ⭐ would be appreciated :)

@timrasche
Copy link
Author

Cool so it will be available later today in 10.0.0.
Nice!
Your ⭐ would be appreciated :)
Sure ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants