Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]: OpenAI Server Command Line Args Broken #4707

Closed
noamgat opened this issue May 9, 2024 · 3 comments 路 Fixed by #4709 or #4729
Closed

[Doc]: OpenAI Server Command Line Args Broken #4707

noamgat opened this issue May 9, 2024 · 3 comments 路 Fixed by #4709 or #4729
Labels
documentation Improvements or additions to documentation

Comments

@noamgat
Copy link
Contributor

noamgat commented May 9, 2024

馃摎 The doc issue

In v0.4.1 (and before), there was full documentation for params:

https://docs.vllm.ai/en/v0.4.1/serving/openai_compatible_server.html#command-line-arguments-for-the-server

In v0.4.2 and master, its empty:

https://docs.vllm.ai/en/v0.4.2/serving/openai_compatible_server.html#command-line-arguments-for-the-server

Suggest a potential alternative/fix

No response

@noamgat noamgat added the documentation Improvements or additions to documentation label May 9, 2024
@simon-mo simon-mo reopened this May 9, 2024
@simon-mo
Copy link
Collaborator

simon-mo commented May 9, 2024

actually it doesn't fixes things.. yet...

@DarkLight1337
Copy link
Collaborator

actually it doesn't fixes things.. yet...

When I built the docs locally, the CLI arguments did show up. Not sure what is different in the CI environment.

@AllenDou
Copy link
Contributor

AllenDou commented May 10, 2024

#4729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
4 participants