Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Option for preemption_mode uses underscore (_) instead of dash (-) #5667

Closed
maharjun opened this issue Jun 19, 2024 · 1 comment 路 Fixed by #5688
Closed

[Bug]: Option for preemption_mode uses underscore (_) instead of dash (-) #5667

maharjun opened this issue Jun 19, 2024 · 1 comment 路 Fixed by #5688
Labels
bug Something isn't working

Comments

@maharjun
Copy link

maharjun commented Jun 19, 2024

Your current environment

Irrelevant, the error is easily seen in the code. It is seen in version 0.5.0.post1, in the file vllm.engine.arg_utils:576

馃悰 Describe the bug

In the latest release (V0.5.0.post1), the CLI argument for preemption_mode parameter of EngineArgs is --preemption_mode which goes against the typical convention of replacing _ with - in command-line parameters. This won't affect any other code if fixed to --preemption-mode, because argparse converts any dashes to underscores in the namespace returned by parser.parse_args(). However the current situation causes problems when I want to convert an EngineArgs instance to set of command-line flags (say in order to launch a vllm server programmatically via subprocess)

@mgoin
Copy link
Collaborator

mgoin commented Jun 19, 2024

Thanks for reporting this @maharjun! I've posted a fix here #5688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants