invalid json response body at .. for empty response (as in OPTIONS) request

[marcin-wosinek]

Same issue as in #409 happens if the response body is empty - an expected behavior, for OPTIONS request

[H1Gdev]

@marcin-wosinek
@vlucas

https://stackoverflow.com/questions/29784398/should-content-type-header-be-present-when-the-message-body-is-empty

So, I do not check body length.(error will be occurred.)

What do you think about this ?

[marcin-wosinek]

To what I've seen in the specs, the content-type is not forbidden for OPTIONS request.

What I thought about as a solution, after proposing #433 is something like:

try {
  body = JSON.parse(response.body);
} catch (error) {
  body = error;
}

In case of my tests, I was not interested in body content - so uncaught exception was a problem. Returning error instead of content, should be clear enough for anybody interested in the body itself.

[H1Gdev]

OPTIONS request is right.

It is also possible to check each HTTP method.

        // Auto-parse JSON
        if (response.headers.has('Content-Type') && response.headers.get('Content-Type').includes('json') && response.status !== 204 && (this._request.method.toUpperCase() === 'OPTIONS' && responseBody.length > 0)) {
          try {
            response._json = JSON.parse(responseBody);
          } catch(e) {
            return Promise.reject(new TypeError(`Invalid json response body: '${responseBody}' at ${this._request.url} reason: '${e.message}'`));
          }
        }

[koooge]

Let me close this issue because it would be solved by #521 .