New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixes. #18
Minor bug fixes. #18
Conversation
@Zshan0 This is great! My only particular point to add is that |
I'm suggesting a few changes that could be discussed and bundled together in this PR itself.
Another suggestion that I would make is that the upcoming unitary hack is a good opportunity to add tests/CI for pyqrack :D |
@Zshan0 Correct, |
I can do |
Honestly, you're probably more aware of Python standards than I am, so I leave the choice for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again! Feel free to merge, whenever you're ready! (I'll likely iterate a release with your changes, sometime today, because that's the precedent PyQrack maintains for support!)
There were a few minor bugs that went unnoticed, a few more of them persist that require discussion that can be continued on this thread before it is merged with the main branch.