Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unitaryhack] Official documentation #22

Merged
merged 2 commits into from Jun 10, 2022

Conversation

Zshan0
Copy link
Contributor

@Zshan0 Zshan0 commented Jun 8, 2022

As mentioned in #16, there is no official documentation present for pyqrack. The documentation was made on the pyqrack.github.io repository and is being added as docstrings in the original source code. To avoid merge conflicts and other python issues, the code present in the files of the website counterpart has no functionality and has only the docstrings attached to the function.

@Zshan0
Copy link
Contributor Author

Zshan0 commented Jun 9, 2022

@WrathfulSpatula If there are any changes that I must make, please let me know in advance since the PR must be merged in a week or so, thanks :D

Copy link
Contributor

@WrathfulSpatula WrathfulSpatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks amazing! I left some significant commentary on this, including a couple of hard requirements for clarification or changes, but I'm hitting "approve" In the interest of unblocking your workflow, because this could basically go in as-is, if it had to.

Maybe my only hard sticking-point is the Pauli enumeration tuples, and I think that's just your formatting tooling pointing to the fact that I introduced a bug there, by putting extraneous commas that were interpreted as tuples. We'll sort it out, though, and this is fantastic overall! Thank you again!

pyqrack/pauli.py Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
pyqrack/qrack_simulator.py Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
pyqrack/qrack_simulator.py Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
pyqrack/qrack_simulator.py Outdated Show resolved Hide resolved
@WrathfulSpatula WrathfulSpatula merged commit 7fd8d54 into unitaryfund:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants