Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated fabric #2 #28

Merged
merged 7 commits into from Oct 11, 2020
Merged

Conversation

vmadalin
Copy link
Owner

Description

Fixes: #2

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage     62.92%   62.92%           
  Complexity      186      186           
=========================================
  Files            62       62           
  Lines           615      615           
  Branches         70       70           
=========================================
  Hits            387      387           
  Misses          206      206           
  Partials         22       22           
Flag Coverage Δ Complexity Δ
#unittest ? ?

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18cfb9f...e651e0e. Read the comment docs.

@vmadalin vmadalin merged commit 29eecff into master Oct 11, 2020
@vmadalin vmadalin deleted the fix/remove-deprecated-fabric branch October 11, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating from Fabric to Firebase
1 participant