Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteUnusedSegments facts caused by an excursion along the route #322

Open
pelderson opened this issue Aug 22, 2023 · 2 comments
Open

RouteUnusedSegments facts caused by an excursion along the route #322

pelderson opened this issue Aug 22, 2023 · 2 comments

Comments

@pelderson
Copy link
Collaborator

The RouteUnusedSegments fact for this route seems to be caused by the side loop.
On the ground the route is continous for the hiker: the signs are put up nicely to guide the hiker through the loop automatically; no user choice involved. From an informational standpoint it is correct to add the common segment twice to the relation, so ideally it shouldn't raise a 'fact'.

Could this be done without additional tagging? If not:

  • I thought about adding forward and backward roles to the common segment, but that would not be compatible with backward and forward roles in (mostly) cycling routes.

  • Possible solution: we could give the side loop members the role "excursion". This role is designed and approved for this situation. However, the excursion should remain included in the route display, distance count, analysis of the segments etc. The role just needs to suppress the error.

@vmarc
Copy link
Owner

vmarc commented Aug 22, 2023

Last saturday I introduced an additional artificial node to cover a similar situation:
Route 79-79 was split in two:

*-79
79-*

This should be a temporay solution / workarround only.

The better solution will be that the knooppuntnet logic does not try to be too smart: when it finds that start and end node are nicely connected by the ways in the relation in the order in which they are in the relation, than it should think no further, stop further analysis and consider the route to be ok as is.

Additional tagging will not make it any easier for the mapper or the knooppuntnet logic I think.

See also: #2 (2017!)

@pelderson
Copy link
Collaborator Author

The better solution will be that the knooppuntnet logic does not try to be too smart: when it finds that start and end node are nicely connected by the ways in the relation in the order in which they are in the relation, than it should think no further, stop further analysis and consider the route to be ok as is.

Agreed! Can't wait! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants