Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for footnotes #239

Closed
djui opened this issue May 7, 2013 · 7 comments
Closed

Add support for footnotes #239

djui opened this issue May 7, 2013 · 7 comments

Comments

@djui
Copy link

djui commented May 7, 2013

redcarpet has with tables, code fence blocks, and many other extensions seems to lack footnote support to complete a set of features kramdown and maruku provide.

@robin850
Copy link
Collaborator

robin850 commented May 7, 2013

Hello,

This seems legit since footnotes are in markdown specs. We should implement it! Thanks for this proposal @djui.

@aprescott
Copy link

I don't think the footnotes being requested are the same as the reference links mentioned in the spec. (They should already be in Redcarpet.) Rather, it's actual rendered footnotes in the HTML, like those that PHP Markdown Extra supports.

@djui
Copy link
Author

djui commented May 7, 2013

@aprescott correct. After some issue crawling in sundown I actually found that this is already requested quite heavily but @vmg wanted to put it on hold (or allow pull requests) as they were working on a standardized markdown specification.

Meanwhile I found fork that implements footnotes and merged that into my redcarpet fork to get it uptodate. It works for me (and was reported to work for many other). However, the decision to progress and integrate this, is up to the core developers, like you guys, @robin850?

@robin850
Copy link
Collaborator

robin850 commented May 8, 2013

I don't think the footnotes being requested are the same as the reference links mentioned in the spec. (They should already be in Redcarpet.) Rather, it's actual rendered footnotes in the HTML, like those that PHP Markdown Extra supports.

Ah, right. I read it too quickly!

@djui : I'm personnaly 👍 with this. I'm most of the time in favor of such improvements (especially when they are still implemented :trollface:).

@mattr- : thoughts on this please?

@mattr-
Copy link
Collaborator

mattr- commented May 8, 2013

I want to see a pull request. 😄

@djui
Copy link
Author

djui commented May 8, 2013

There you go: #241

@robin850
Copy link
Collaborator

Finally, #271 has been merged. We can close this. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants