Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header referenced image not rendered properly #670

Open
jpsim opened this issue Jan 20, 2019 · 0 comments
Open

Header referenced image not rendered properly #670

jpsim opened this issue Jan 20, 2019 · 0 comments

Comments

@jpsim
Copy link

jpsim commented Jan 20, 2019

First off, thank you very much for this gem. It's been powering a Swift & Objective-C documentation generator for years, and I'm very grateful! 馃檹

We recently ran into a bug where referenced images (as opposed to inlined) in a header element wouldn't be rendered properly. See this small example:

$ cat README.md      
# H1 ![logo1] ![logo2] [![logo3](https://example.com/logo3.svg)](https://example.com)

[logo1]: https://example.com/logo1.svg
[logo2]: https://example.com/logo2.svg
$ redcarpet --version
Redcarpet 3.4.0
$ redcarpet README.md
<h1>H1 <img src="https://example.com/logo1.svg" alt="logo1"> ![logo2] <a href="https://example.com"><img src="https://example.com/logo3.svg" alt="logo3"></a></h1>

In this case, logo1 and logo3 are properly rendered as HTML but not logo2. Any assistance in resolving this would be greatly appreciated!

Original report here: realm/jazzy#1040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant