Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garvity sync backup #167

Closed
kormoan opened this issue Feb 13, 2021 · 8 comments · Fixed by #164
Closed

garvity sync backup #167

kormoan opened this issue Feb 13, 2021 · 8 comments · Fixed by #164
Assignees
Labels
bug Something isn't working

Comments

@kormoan
Copy link

kormoan commented Feb 13, 2021

gravity sync backup version 3.1.1 doens't delete old backups. Sd card runs out of space. Backup retain is set to 3. any ideas?

@soonic6
Copy link

soonic6 commented Feb 13, 2021

you have to update gravity sync with ./gravity-sync.sh update
this bug was fixed in 3.2.6

Source: https://github.com/vmstan/gravity-sync/discussions/151#discussioncomment-364710

@kormoan
Copy link
Author

kormoan commented Feb 13, 2021

Ok. Did it.

Deletion doesn't work either. The backup folder contains multiple files created last year.

grafik

The backup_cleanup function only searhes for files created in the current year (2021).

grafik

I think tihs should be change. Otherwise it wastes storage space every turn of the year.

@vmstan vmstan linked a pull request Feb 14, 2021 that will close this issue
@vmstan vmstan self-assigned this Feb 14, 2021
@vmstan vmstan added the bug Something isn't working label Feb 14, 2021
@vmstan
Copy link
Owner

vmstan commented Feb 14, 2021

2020 just won't leave us alone!

@jsuelwald
Copy link

jsuelwald commented Apr 1, 2021

I'd like to re-open this issue, as i've recently installed github-sync.
Limit for backups is set to 2, but old backups aren't deleted at all.

root@ct-pihole-backup:~/gravity-sync# ./gravity-sync.sh
[∞] Gravity Sync 3.3.2 Executing
[✓] Importing gravity-sync.conf Settings
[✓] Evaluating Arguments: SMART Requested
[i] Targeting root@192.168.0.2
[✓] Validating SSH Client on ct-pihole-backup (OpenSSH)
[✓] Validating RSYNC Installed on ct-pihole-backup
[✓] Validating Gravity Sync Folders on ct-pihole-backup
[✓] Validating Pi-hole Configuration
[✓] Validating DNSMASQ Configuration
[✓] Validating SQLITE Installed on ct-pihole-backup
[✓] Validating Connection to 192.168.0.2
[i] Starting SMART Analysis
[✓] Analyzing gravity.db on 192.168.0.2
[✓] Analyzing gravity.db on ct-pihole-backup
[!] Differenced gravity.db Detected
[✓] Analyzing custom.list on 192.168.0.2
[✓] Analyzing custom.list on ct-pihole-backup
[i] No 05-pihole-custom-cname.conf Detected on ct-pihole-backup
[!] Replication Required
[!] Both gravity.db Have Changed
[!] Secondary gravity.db Last Changed
[✓] Performing Backup of Remote gravity.db
[✓] Performing Backup of Local gravity.db
[✓] Copying gravity.db from 192.168.0.2
[✓] Pushing gravity.db to 192.168.0.2
[✓] Setting Permissions on gravity.db
[✓] Setting Ownership on gravity.db
[i] Isolating Regeneration Pathways
[✓] Updating FTLDNS Configuration
[✓] Reloading FTLDNS Services
[i] Inverting Tachyon Pulses
[✓] Updating Remote FTLDNS Configuration
[✓] Reloading Remote FTLDNS Services
[i] Performing Replicator Diagnostics
[✓] Reanalyzing gravity.db on 192.168.0.2
[✓] Reanalyzing gravity.db on ct-pihole-backup
[✓] Reanalyzing custom.list on 192.168.0.2
[✓] Reanalyzing custom.list on ct-pihole-backup
[i] No 05-pihole-custom-cname.conf Detected on ct-pihole-backup
[✓] Scrubbing 2 Redundant Antimatter Containment Pods
[✓] Saving File Hashes
[✓] Logging Successful SMART
[∞] Gravity Sync SMART Completed (22 seconds)
root@ct-pihole-backup:~/gravity-sync# du -h backup
4.4G    backup

root@ct-pihole-backup:~/gravity-sync# cat settings/gravity-sync.conf | grep -i backup
### Backup Customization
BACKUP_RETAIN='2'                       # replace in gravity-sync.conf to overwrite
# BACKUP_FOLD=''                        # must exist as subdirectory in LOCAL_FOLDR

@vmstan
Copy link
Owner

vmstan commented Apr 1, 2021

How many files does it actually retain? I noticed you have "Both gravity.db Have Changed" in your log above, do you see that often? I wonder if you have changes every time it's ran.

@jsuelwald
Copy link

jsuelwald commented Apr 2, 2021

How many files does it actually retain? I noticed you have "Both gravity.db Have Changed" in your log above, do you see that often? I wonder if you have changes every time it's ran.

I ran this command 3 times yesterday with 2-3 minutes apart. i didn't change anything else during this (blocklists and so forth were the same)

@jsuelwald
Copy link

After reviewing the Log, esp. the "No 05-pihole-custom-cname.conf Detected on ct-pihole-backup" - messagte i created the file on my original pihole (it was missing there too, because i've never created any custom DNS names)

Can this cause the problem with the backup?

@jsuelwald
Copy link

root@ct-pihole-backup:~/gravity-sync/backup# ../gravity-sync.sh sync
[∞] Gravity Sync 3.3.2 Executing
[✓] Importing gravity-sync.conf Settings
[✓] Evaluating Arguments: SMART Requested
[i] Targeting root@192.168.0.2
[✓] Validating SSH Client on ct-pihole-backup (OpenSSH)
[✓] Validating RSYNC Installed on ct-pihole-backup
[✓] Validating Gravity Sync Folders on ct-pihole-backup
[✓] Validating Pi-hole Configuration
[✓] Validating DNSMASQ Configuration
[✓] Validating SQLITE Installed on ct-pihole-backup
[✓] Validating Connection to 192.168.0.2
[i] Starting SMART Analysis
[✓] Analyzing gravity.db on 192.168.0.2
[✓] Analyzing gravity.db on ct-pihole-backup
[✓] Analyzing custom.list on 192.168.0.2
[✓] Analyzing custom.list on ct-pihole-backup
[✓] Analyzing 05-pihole-custom-cname.conf on 192.168.0.2
[✓] Analyzing 05-pihole-custom-cname.conf on ct-pihole-backup
[i] No Replication Required
[✓] Scrubbing 2 Redundant Antimatter Containment Pods
[∞] Gravity Sync SMART Aborting (1 seconds)

Aborting?

root@ct-pihole-backup:~/gravity-sync/backup# ls -l
total 282592
-rw-r--r-- 1 root root        0 Apr  4 13:18 05-pihole-custom-cname.conf.pull
-rw-r--r-- 1 root root        0 Apr  4 13:17 2021-04-04-131706-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  4 13:17 2021-04-04-131706-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  4 13:18 2021-04-04-131826-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  4 13:18 2021-04-04-131826-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  4 13:19 2021-04-04-131901-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  4 13:19 2021-04-04-131901-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  4 13:19 2021-04-04-131901-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:04 2021-04-06-080456-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:04 2021-04-06-080456-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:04 2021-04-06-080456-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:05 2021-04-06-080525-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:05 2021-04-06-080525-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:05 2021-04-06-080525-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:24 2021-04-06-082401-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:24 2021-04-06-082401-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:24 2021-04-06-082401-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:25 2021-04-06-082530-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:25 2021-04-06-082530-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:25 2021-04-06-082530-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  4 13:18 custom.list.pull
-rw-r--r-- 1 root root 36171776 Apr  4 13:18 gravity.db.pull

root@ct-pihole-backup:~/gravity-sync/backup# ../gravity-sync.sh backup
[∞] Gravity Sync 3.3.2 Executing
[✓] Importing gravity-sync.conf Settings
[✓] Evaluating Arguments: BACKUP Requested
[✓] Performing Backup of Local gravity.db
[✓] Performing Backup Up Local custom.list
[✓] Performing Backup Up Local 05-pihole-custom-cname.conf
[✓] Scrubbing 2 Redundant Antimatter Containment Pods
[✓] Logging Successful BACKUP
[∞] Gravity Sync BACKUP Completed (1 seconds)

root@ct-pihole-backup:~/gravity-sync/backup# ls -l
total 317916
-rw-r--r-- 1 root root        0 Apr  4 13:18 05-pihole-custom-cname.conf.pull
-rw-r--r-- 1 root root        0 Apr  4 13:17 2021-04-04-131706-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  4 13:17 2021-04-04-131706-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  4 13:18 2021-04-04-131826-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  4 13:18 2021-04-04-131826-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  4 13:19 2021-04-04-131901-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  4 13:19 2021-04-04-131901-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  4 13:19 2021-04-04-131901-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:04 2021-04-06-080456-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:04 2021-04-06-080456-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:04 2021-04-06-080456-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:05 2021-04-06-080525-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:05 2021-04-06-080525-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:05 2021-04-06-080525-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:24 2021-04-06-082401-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:24 2021-04-06-082401-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:24 2021-04-06-082401-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:25 2021-04-06-082530-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:25 2021-04-06-082530-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:25 2021-04-06-082530-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  6 08:26 2021-04-06-082619-05-pihole-custom-cname.conf.backup
-rw-r--r-- 1 root root        0 Apr  6 08:26 2021-04-06-082619-custom.list.backup
-rw-r--r-- 1 root root 36171776 Apr  6 08:26 2021-04-06-082619-gravity.db.backup
-rw-r--r-- 1 root root        0 Apr  4 13:18 custom.list.pull
-rw-r--r-- 1 root root 36171776 Apr  4 13:18 gravity.db.pull

And this shows, that backup created a new backup and didn't delete older backups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants