Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Grafana Docker image #12

Closed
arapulido opened this issue Mar 22, 2018 · 5 comments
Closed

Grafana Docker image #12

arapulido opened this issue Mar 22, 2018 · 5 comments

Comments

@arapulido
Copy link
Contributor

No description provided.

@anguslees anguslees mentioned this issue Mar 26, 2018
8 tasks
@arapulido arapulido moved this from Backlog to Committed in Docker images and manifests Mar 26, 2018
@silviofdez silviofdez moved this from Committed to In Progress in Docker images and manifests Mar 26, 2018
@silviofdez
Copy link

@silviofdez
Copy link

@anguslees @arapulido could you please if this fits you?

@silviofdez silviofdez moved this from In Progress to Waiting For Review in Docker images and manifests Mar 26, 2018
@anguslees
Copy link
Contributor

anguslees commented Mar 26, 2018

Wow, thanks!

Some questions:

Why is the container CMD tail -f /dev/null?
https://github.com/bitnami/kube-prod-containers/blob/dc70c49a412fa126049397e327f5544f66d0171a/grafana/Dockerfile#L32
Harmless, since all the action happens in entrypoint=run.sh,

Why do we create the user and change permissions after the container is started? (in run.sh)
In a k8s context, I would have expected this to just be an image with the grafana-server binary (all owned as root:root), and then the k8s container would specify runAsUser: 1001 or something, so the container was never root. I think as written that it must be started as root - just to do a few steps that could have been done at container-build-time.

If the answer is: that's the normal way our standard automated approach generates things, then that's fine. I'm pretty sure I can work around this easily from k8s by skipping run.sh and just directly running grafana-server as my desired uid directly.

@anguslees
Copy link
Contributor

Oh also, it's easier to discuss changes in github while they're still a pull-request (the UI allows per-line comments, etc) - rather than after they're merged. @silviofdez If that fits your workflow ok, we should probably do that in future.

@arapulido arapulido moved this from Waiting For Review to Paused in Docker images and manifests Apr 9, 2018
@arapulido arapulido moved this from Paused to Done in Docker images and manifests Apr 9, 2018
@arapulido
Copy link
Contributor Author

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants