Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

diff subcommand should ignore gc tag #316

Open
kgtw opened this issue Sep 27, 2021 · 2 comments
Open

diff subcommand should ignore gc tag #316

kgtw opened this issue Sep 27, 2021 · 2 comments
Assignees
Labels

Comments

@kgtw
Copy link

kgtw commented Sep 27, 2021

We run the diff subcommand during CI process involved with PR reviews, which comments back the diff as a PR comment in github.

When this happens we are getting false/positives because in some cases the only difference is the gc tag.

"metadata": {
-      "annotations": {
-       "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
-      },
-      "labels": {
-       "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
-      },

Either the diff subcommand should ignore the gc tag entirely, or the option to provide it should be made available to avoid such instances of this happening.

@mkmik mkmik self-assigned this Sep 27, 2021
@mkmik mkmik added the bug label Sep 27, 2021
@mkmik
Copy link
Contributor

mkmik commented Sep 27, 2021

which --diff-strategy are you using?

@kgtw
Copy link
Author

kgtw commented Sep 27, 2021

diff --diff-strategy last-applied

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants