Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Integration test #8

Open
glyn opened this issue Nov 20, 2019 · 2 comments
Open

Integration test #8

glyn opened this issue Nov 20, 2019 · 2 comments
Assignees

Comments

@glyn
Copy link
Contributor

glyn commented Nov 20, 2019

As pointed out in https://github.com/pivotal/kubernetes-image-mapper/pull/2/files#r348191945, controller runtime has a standard way of implementing integration tests. We should consider adding an integration test, particularly if there are scenarios which turn out to be hard to unit test.

@glyn glyn mentioned this issue Nov 20, 2019
@glyn glyn self-assigned this Nov 20, 2019
@glyn
Copy link
Contributor Author

glyn commented Nov 20, 2019

With kube-apiserver v1.15.5 and earlier, I get an intermittent error in the integration tests:

ERROR	controller-runtime.metrics	failed to register metric	{"name": "workqueue_retries_total", "queue": "imagemap", "error": "duplicate metrics collector registration attempted"}

(full logs). This may be related to kubernetes/kubernetes#76956, so I'm asking on kubernetes slack where to get v1.16.x of kube-apiserver to see if that helps.

@glyn
Copy link
Contributor Author

glyn commented Nov 20, 2019

Also seeing an intermittent/frequent integration test failure where an image map cannot be created because it is still being deleted. This happens even if I wait after the deletion until I can no longer get the image map. More investigation needed...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant