Using **kwargs in _connect() of DeviceComms and DccComms

[Venkat2811]

Data members required for establishing connection in Transport layer are stored in init() method of DeviceComms and DccComms, so that self._connect() can be called. This results in duplication.

Why don't we use **kwargs in abstract _connect() method, so that it can take dynamic arguments instead ?

[Venkat2811]

Hi @bfrggit,

Could you please explain why self._connect() should be kept free of external arguments as mentioned in the comment here ?

If it is to facilitate dynamic number of arguments as each transport requires different arguments, why don't we use _connect(**kwargs) instead ?

Adding @KohliDev

[bfrggit]

We want to keep the parameters.

At the same time, if we put the parameters in _connect(), it gives the possibility that some one call this method on the same obj multiple times with different parameters, which may cause troubles.

Of course you could always resolve these problems in some ways, whether you decide to use an init() or use _connect() directly. We just decided to use the first manner. In this way it might also be more consistent with other modules and classes.

[Venkat2811]

Oh okay. Thanks for explaining.