Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

OPSMAN_URI parameter likely redundant #68

Closed
akumria opened this issue May 14, 2017 · 3 comments
Closed

OPSMAN_URI parameter likely redundant #68

akumria opened this issue May 14, 2017 · 3 comments

Comments

@akumria
Copy link

akumria commented May 14, 2017

See ref: https://github.com/pivotal-cf/aws-concourse/issues/13

This is just a copy of that issue.

@bijukunjummen
The OPSMAN_URI parameter is likely to be redundant - in some of the pipeline steps it is derived as https://opsman.$ERT_DOMAIN, if by any chance a different OPSMAN_URI is provided the import-stemcell step fails as the url's don't match up. We should either use OPSMAN_URI at all places or remove OPSMAN_URI and derive the url.

@ryanpei
@bijukunjummen so we would replace OPSMAN_URI with ERT_DOMAIN in all places where it is > currently used?

@bijukunjummen
Yes, I think so @ryanpei, OR make use of the OPSMAN_URI everywhere a opsman's url is required instead of deriving it as https://opsman.$ERT_DOMAIN. Former may be a good start though.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@akumria
Copy link
Author

akumria commented May 14, 2017

Personally I think it would be simpler to consistently use OPSMAN_URI everywhere. Then the derivation can be done once -- and also allow for overrides.

It might also help for https://github.com/pivotal-cf/aws-concourse/issues/14 too

In particular it will have with the use-case as noted in: #51 (comment)

@krishicks
Copy link
Contributor

I don't agree with the original issue. We use OPSMAN_URI directly all over the place. Perhaps in the scope of aws-concourse it wasn't, but no matter as aws-concourse is deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants