Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Heroku deploy script doesn't work #137

Closed
mreider opened this issue May 6, 2019 · 7 comments
Closed

Heroku deploy script doesn't work #137

mreider opened this issue May 6, 2019 · 7 comments

Comments

@mreider
Copy link

mreider commented May 6, 2019

Hi there.

A couple of issues.

  1. When I try to run the deploy-heroku.sh script it complains about directory references. So I had to copy the file into the /deployments/heroku directory. All good now.

  2. Buildpack looks wrong:

remote:
remote: -----> App not compatible with buildpack: https://buildpack-registry.s3.amazonaws.com/buildpacks/heroku/ruby.tgz
remote: More info: https://devcenter.heroku.com/articles/buildpacks#detection-failure
remote:
remote: ! Push failed
remote: Verifying deploy...
remote:
remote: ! Push rejected to em-retros1.

@loganripplinger
Copy link

I have the same issue.

@emgord
Copy link

emgord commented May 29, 2019

I am also having the same issue

@emgord
Copy link

emgord commented May 30, 2019

I was able to get the deploy script to work by first installing the npm packages from the web directory, and then running the package.sh script in the root. This created a package.zip of the build ready for deployment on each platform, and the instructions worked from there.

@textbook
Copy link
Contributor

I just successfully ran ./deploy.sh <client-app> <server-app> in /package/heroku using postfacto-3.0.1.zip file from the release. There was no problem with script location or buildpack detection.

If you're trying to do this from a clone of the repo or the source code download then yes, you'll need to run package.sh to actually build the deployment package. If you have deploy-heroku.sh, rather than heroku/deploy.sh, you're not using the right asset.

@textbook
Copy link
Contributor

@seadowg do you know what happened to the package.zip from the 3.1.3 release? It looks like it got created in the build but never made it to the release.

@seadowg
Copy link
Contributor

seadowg commented Jul 11, 2019

No idea! In .travis.yml you'll see that it only "deploys" on tags. It could be that the key being used is tied to my account so you need to regenerate. A lot of Github plugins tie everything to a user (annoying I know) so potentially making a shared Github account for things like that could be helpful.

@textbook
Copy link
Contributor

textbook commented Jul 18, 2019

I've just cut a new release (3.2.0) that has the zipped package file correctly uploaded to it - let me know if you have any problems deploying to Heroku from that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants