Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Installation and build fixes #2

Closed
kerneltime opened this issue Jan 30, 2016 · 1 comment
Closed

Installation and build fixes #2

kerneltime opened this issue Jan 30, 2016 · 1 comment
Labels

Comments

@kerneltime
Copy link
Contributor

Filling the issues Mark and I encountered with the build on a new machine.

  • Code layout should be split into common backend and docker plugin. Common backend will eventually be a separate repo shared by others (kube)
  • libc6-dev-i386 is missing from default ubuntu and needs to be packaged in the containerized build
  • GOPATH in Makefile assumes go modules and dvolplug source in the same mounted folder. This breaks the build, because bind mount hides docker pulled packages.
  • Fix message when dvolplug runs (ignored and it's OK)
@kerneltime
Copy link
Contributor Author

  • %s/mkfs is wrong in the py code.
  • pvscsi adapter is required but not created or validated

@msterin msterin self-assigned this Feb 1, 2016
ashahi1 referenced this issue in ashahi1/docker-volume-vsphere Jan 23, 2017
# This is the 1st commit message:

Improving vmdk_ops_test.py

Addressed review comments

Fixed the issue in the code which cause CI failure in previous run - (too-many-function-args)

# This is the commit message #2:

Addressed Nirdesh's comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants