Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Capture plugin code coverage #869

Closed
1 of 3 tasks
kerneltime opened this issue Jan 20, 2017 · 1 comment
Closed
1 of 3 tasks

Capture plugin code coverage #869

kerneltime opened this issue Jan 20, 2017 · 1 comment

Comments

@kerneltime
Copy link
Contributor

kerneltime commented Jan 20, 2017

When test coverage is run for go plugin the test code does not measure the code coverage of the plugin but only the test and the functions it depends on. The actual execution is done via a RPC call over docket.

  • To measure the test coverage correctly the go plugin needs to run in an instrumented manner.
  • Generate an instrumented vDVS plugin binary
  • Generate a managed plugin that uses instrumented vDVS plugin binary
@pdhamdhere pdhamdhere added this to the v1 GA milestone Feb 1, 2017
@shuklanirdesh82 shuklanirdesh82 modified the milestones: 0.16 , v1 GA May 31, 2017
@shuklanirdesh82 shuklanirdesh82 changed the title Test coverage can be misleading Test coverage can be misleading for E2E tests May 31, 2017
@tusharnt tusharnt added the P0 label May 31, 2017
@tusharnt tusharnt changed the title Test coverage can be misleading for E2E tests Capture plugin code coverage Jun 28, 2017
@tusharnt tusharnt modified the milestones: 0.17, 0.16 Jun 28, 2017
@shuklanirdesh82 shuklanirdesh82 modified the milestones: simba, 0.17 Jun 29, 2017
@shuklanirdesh82 shuklanirdesh82 modified the milestones: Biweekly sprint - Timon, Biweekly sprint - Simba, 0.17 Jul 17, 2017
@shuklanirdesh82
Copy link
Contributor

When test coverage is run for go plugin the test code does not measure the code coverage of the plugin but only the test and the functions it depends on. The actual execution is done via a RPC call over docket.

the original issue was filed to keep track off above issue. I have verified that code coverage is captured correctly whenever the execution is done via RPC over socket/remote docker end point.

Generate an instrumented vDVS plugin binary

#1589 is raised to track this issue.

Generate a managed plugin that uses instrumented vDVS plugin binary
#1590 is raised to achieve this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants