Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datalist control does not respect clrLabelSize value above 2 in horizontal or compact layouts #128

Closed
3 of 8 tasks
arcmodo opened this issue Jul 26, 2022 · 2 comments
Closed
3 of 8 tasks

Comments

@arcmodo
Copy link

arcmodo commented Jul 26, 2022

Describe the bug

When specifying clrLabelSize > 2 in a compact or horizontal layout, the datalist component is ignoring clrLabelSize.

How to reproduce

Clarity Angular v13 and Core v6 Stackblitz.

Steps to reproduce the behavior:

  1. In a basic Clarity Core/Angular app, set your form clrLayout="compact", "horizontal" or default and clrLabelSize="4"
  2. Add various controls such as input, select, etc., but be sure to include the datalist control
  3. All controls will properly respect clrLabelSize="4" for layout, except for the datalist control

Expected behavior

The datalist control should respect the clrLabelSize value of 4

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
Angular v13

Device:

  • Type: [Dell Notebook]
  • OS: [Windows 10]
  • Browser: [Edge (Chromium)]
  • Version: [103]

Additional notes

This is an issue in Edge 103 and Chrome 103. Note from one of our developers, "I noticed in Clarity source code that the label columns were increased from 2 to 4 for most of the form controls except the datalist. Before the change, label was given 2 columns width and form control 10 columns. After the change, it is label 4 columns and form control 8 columns, except for datalist which appears to remain at 2 columns."

image

@ashleyryan
Copy link
Contributor

Clarity Core has no knowledge of clr/ui (the clr prefix you're mentioning). It does not, and will not, respect Clarity NG or Clr/ui properties. It's recommended to switch your whole form to Core, if something isn't working as expected

@ashleyryan ashleyryan reopened this Jul 28, 2022
@ashleyryan ashleyryan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants