Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): remove hover bg color change when disabled #135

Merged
merged 1 commit into from Aug 3, 2022

Conversation

ashleyryan
Copy link
Contributor

fixes #134

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

When hovering over a disabled clickable tag, the background color still changes

Issue Number: #134

What is the new behavior?

The background color no longer changes on hover, when disabled

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

👋 @ashleyryan,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@ashleyryan
Copy link
Contributor Author

Hey @colinreedmiller I'm not sure if you want to review this: https://135--storybook-core-clarity-design.netlify.app/?path=/story/components-tag--page (scroll down to clickable tags and you'll see two rows of disabled tags). I made an assumption that we don't want to change the background color on colored tags on hover when they're disabled, can you confirm?

@ashleyryan ashleyryan self-assigned this Aug 3, 2022
@colinreedmiller
Copy link

@ashleyryan Thanks for looping me in. This change implements the correct behavior.

@ashleyryan ashleyryan merged commit d8f4565 into main Aug 3, 2022
@ashleyryan ashleyryan deleted the asryan/tag-disabled-color branch August 4, 2022 13:11
@github-actions
Copy link

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When CdsTag has both color and disabled hover functionality still works.
4 participants