feat(file): allow custom button label #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Feature
What is the current behavior?
The
buttonLabel
property oncds-file
can be set even though it is private. When the file selection is cleared, the button label is reset to "Browse" instead of the previousbuttonLabel
value.Issue Number: CDE-1055
What is the new behavior?
A custom button label is fully supported.
Does this PR introduce a breaking change?
No.
Other Information
buttonLabel
property is nowpublic
.buttonLabelForSelection
. This property isprivate
and should not be set externally.