Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file): allow custom button label #295

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat(file): allow custom button label #295

merged 1 commit into from
Mar 20, 2024

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Feb 26, 2024

PR Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Feature

What is the current behavior?

The buttonLabel property on cds-file can be set even though it is private. When the file selection is cleared, the button label is reset to "Browse" instead of the previous buttonLabel value.

Issue Number: CDE-1055

What is the new behavior?

A custom button label is fully supported.

Does this PR introduce a breaking change?

No.

Other Information

  • The buttonLabel property is now public.
  • The is a new property named buttonLabelForSelection. This property is private and should not be set externally.

Copy link

github-actions bot commented Feb 26, 2024

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann changed the title feat(file): allow customizable button label feat(file): allow custom button label Feb 26, 2024
Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann kevinbuhmann merged commit 62d7b9f into main Mar 20, 2024
1 check passed
@kevinbuhmann kevinbuhmann deleted the kevin/cde-1055 branch March 20, 2024 19:04
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants