Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(react): upgrade to react 17 and remove enzyme #7

Merged
merged 1 commit into from Mar 18, 2022

Conversation

ashleyryan
Copy link
Contributor

  • add react-testing-library
  • upgrade jest/jsdom dependencies

Signed-off-by: Ashley Ryan asryan@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ashleyryan
Copy link
Contributor Author

5th time is the charm - this is going to be a lot more of a pain to bring to the main branch

@ashleyryan ashleyryan self-assigned this Mar 18, 2022
@coryrylan
Copy link
Contributor

I don't have any strong opinion/insight on this needing to be backported to main/v5. Might be fine just remaining on beta/v6 only?

@ashleyryan
Copy link
Contributor Author

My only concern with not backporting it to v5 is that any fixes we make might be difficult to cherry-pick back into v5 if the react folder is so different.

But I guess we don't really do that much as far as react testing goes, so we probably won't need to make any changes there if we're fixing a core bug

@mathisscott
Copy link
Contributor

My only concern with not backporting it to v5 is that any fixes we make might be difficult to cherry-pick back into v5 if the react folder is so different.

🤔 I'm not a fan of backporting this to v5. If the need becomes dire, then maybe we can address it at that time?

@ashleyryan
Copy link
Contributor Author

If the need becomes dire, then maybe we can address it at that time?

Works for me. It's unlikely anyone will be editing the react unit tests anyway

- add react-testing-library
- upgrade jest/jsdom dependencies

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@ashleyryan ashleyryan merged commit 97d1396 into vmware-clarity:beta Mar 18, 2022
@ashleyryan ashleyryan deleted the react-17 branch March 18, 2022 19:42
@github-actions
Copy link

🎉 This PR is included in version 6.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants