New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update package-lock.json after npm install
#118
chore: update package-lock.json after npm install
#118
Conversation
Thank you, 🤖 Clarity Release Bot |
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
What version of node and npm are you using? I can't replicate this? |
FWIW, I keep getting this too. I've been meaning to ask you about it - usually I delete the package.lock before committing |
Deleting package.lock will likely cause dependencies to update. We probably want to be careful doing this. I wonder if different npm versions are causing minor changes here. |
Node v16.15.0 |
I think Ashley meant that she discards the changes. |
Ah, that makes sense. |
This isn't happening for me anymore. |
If you have changes to your lock file and you didn't update any First, undo your changes to the lock file. Next, run the following: If your lock file changes went away, then you just had a bad lock file somehow and all should be good. If you still see changes to your lock file after this, that means the last commit didn't properly update the lock file. In this case, we should make a chore commit to update the bad lock file. If this becomes an issue we can add an automated check to the CI/CD that will prevent merging a PR if the lock file is out of sync. |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information