Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package-lock.json after npm install #118

Closed
wants to merge 1 commit into from
Closed

chore: update package-lock.json after npm install #118

wants to merge 1 commit into from

Conversation

kevinbuhmann
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
@steve-haar
Copy link
Contributor

What version of node and npm are you using? I can't replicate this?

@ashleyryan
Copy link

FWIW, I keep getting this too. I've been meaning to ask you about it - usually I delete the package.lock before committing

@steve-haar
Copy link
Contributor

FWIW, I keep getting this too. I've been meaning to ask you about it - usually I delete the package.lock before committing

Deleting package.lock will likely cause dependencies to update. We probably want to be careful doing this. I wonder if different npm versions are causing minor changes here.

@kevinbuhmann
Copy link
Member Author

What version of node and npm are you using? I can't replicate this?

Node v16.15.0
npm v8.1.0

@kevinbuhmann
Copy link
Member Author

Deleting package.lock will likely cause dependencies to update.

I think Ashley meant that she discards the changes.

@steve-haar
Copy link
Contributor

Deleting package.lock will likely cause dependencies to update.

I think Ashley meant that she discards the changes.

Ah, that makes sense.

@kevinbuhmann
Copy link
Member Author

This isn't happening for me anymore. git clean -fdx fixed it. Updating npm probably had something to do with it also.

@kevinbuhmann kevinbuhmann deleted the kbuhmann/sync-package-lock branch May 18, 2022 15:17
@steve-haar
Copy link
Contributor

steve-haar commented May 18, 2022

If you have changes to your lock file and you didn't update any package.json files, then either you have the lock file in a bad state or the last commit left the lock file in a bad state. Here is how to see which scenario you are in:

First, undo your changes to the lock file. Next, run the following: git clean -fxd; nvm use; npm install.

If your lock file changes went away, then you just had a bad lock file somehow and all should be good.

If you still see changes to your lock file after this, that means the last commit didn't properly update the lock file. In this case, we should make a chore commit to update the bad lock file.

If this becomes an issue we can add an automated check to the CI/CD that will prevent merging a PR if the lock file is out of sync.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants