Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up template whitespace #145

Merged
merged 7 commits into from Jun 8, 2022
Merged

chore: clean up template whitespace #145

merged 7 commits into from Jun 8, 2022

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented May 31, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

👋 @,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@ashleyryan
Copy link

ashleyryan commented Jun 1, 2022

Is this a change to the linter or prettier config? I don't see a config file change

@kevinbuhmann
Copy link
Member Author

kevinbuhmann commented Jun 1, 2022

Is this a change to the linter or prettier config? I don't see a config file change

No. I just cleaned up the odd whitespace formatting prettier introduced to make the HTML more readable.

@ashleyryan
Copy link

No. I just cleaned up the odd whitespace formatting prettier introduced to make the HTML more readable.

Right, so manually fixing things is not going to be a longer term fix. If prettier is doing this - we need to fix the prettier config so it doesn't happen again. The next time someone edits one of these files and hits save, prettier will mangle it again.

@kevinbuhmann
Copy link
Member Author

Prettier won't mangle these changes.

@kevinbuhmann
Copy link
Member Author

kevinbuhmann commented Jun 1, 2022

Prettier preserves existing whitespace which 1) mangles tags when adding newlines and 2) keeps unnecessary whitespace when removing newlines. The commits in this PR change insignificant whitespace and prettier will respect that.

@kevinbuhmann kevinbuhmann marked this pull request as draft June 1, 2022 16:39
@kevinbuhmann kevinbuhmann marked this pull request as ready for review June 1, 2022 18:23
Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport to supported version branches too, or we may have troubles cherrypicking and merging future backports in these files.

@kevinbuhmann kevinbuhmann merged commit ab3d8b7 into vmware-clarity:main Jun 8, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/html-formatting branch June 8, 2022 20:47
@kevinbuhmann
Copy link
Member Author

Please backport to supported version branches too, or we may have troubles cherrypicking and merging future backports in these files.

This is backported in #161.

@kevinbuhmann kevinbuhmann added this to For Review in Clarity Angular via automation Jun 9, 2022
@kevinbuhmann kevinbuhmann moved this from For Review to Done in Clarity Angular Jun 9, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants