Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix contributing docs "npm build" does not work #224

Merged
merged 1 commit into from Jul 5, 2022

Conversation

derkoe
Copy link
Contributor

@derkoe derkoe commented Jul 4, 2022

Just started with another PR and saw that there is a small error in the docs/CONTRIBUTING_DEVELOPMENT.md file.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@vmwclabot
Copy link

@derkoe, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

👋 @derkoe,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@vmwclabot
Copy link

@derkoe, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change isn't a fix to the library, please reword the commit message to chore so that this doesn't cause a version bump.

steve-haar
steve-haar previously approved these changes Jul 5, 2022
@steve-haar steve-haar dismissed their stale review July 5, 2022 15:21

need commit message changed

@vmwclabot
Copy link

@derkoe, VMware has approved your signed contributor license agreement.

@derkoe
Copy link
Contributor Author

derkoe commented Jul 5, 2022

@kevinbuhmann done

@kevinbuhmann kevinbuhmann changed the title fix: contributing docs "npm build" does not work chore: contributing docs "npm build" does not work Jul 5, 2022
@kevinbuhmann
Copy link
Member

Thanks! I'll merge as soon as the build passes.

@kevinbuhmann kevinbuhmann merged commit 0aef440 into vmware-clarity:main Jul 5, 2022
@kevinbuhmann kevinbuhmann changed the title chore: contributing docs "npm build" does not work chore: fix contributing docs "npm build" does not work Jul 5, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants