Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary explicit public access modifiers #363

Merged
merged 1 commit into from Oct 31, 2022

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Oct 31, 2022

The public access modifier was inconsistently used. This change makes the code more concise and consistent.

PR Checklist

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Code style update

Does this PR introduce a breaking change?

No

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

The `public` access modifier was inconsistently used. This change makes
the code more concise and consistent.
@kevinbuhmann kevinbuhmann merged commit 49c7e80 into main Oct 31, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/remove-public-modifiers branch October 31, 2022 17:55
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kevinbuhmann added a commit that referenced this pull request Nov 14, 2022
kevinbuhmann added a commit that referenced this pull request Nov 14, 2022
This can cause the rules to be included more than once in the output
when a partial is imported more than once. This happens when using the
dark theme.

This fix can reduce bundle sizes.

part of #363
@kevinbuhmann
Copy link
Member Author

The above commit references were typos.

kevinbuhmann added a commit that referenced this pull request Nov 16, 2022
kevinbuhmann added a commit that referenced this pull request Nov 16, 2022
This can cause the rules to be included more than once in the output
when a partial is imported more than once. This happens when using the
dark theme.

This fix can reduce bundle sizes.

part of #363
@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants