New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClrVerticalNavGroup caret should not be visible without children #396
Comments
I do not understand this request. |
Thanks, makes sense now. I updated the title. |
You shouldn't have a vertical nav group with zero children. I think this is simply incorrect usage of the vertical nav. |
No, the menu without children is normal. The menu data source API filters permissions. |
I'm saying the vertical nav is not designed to have groups with zero children. A nav group with no caret would look identical to a nav link, but it would not function like a nav link. This would be a bad UX. Also, a nav group with zero children doesn't make sense. Clicking a nav group expands it, but if it has no children, nothing will happen. As I stated above, this is simply incorrect usage of the vertical nav.
I think you should hide the nav group entirely if the user doesn't have permission for any of the children. |
I am going to close this as resolved as explained above. |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
It is recommended to add controllable down arrow (left arrow) to clr vertical nav group component.
For example:
<cds-icon
*ngIf="hasChildren"
shape="angle"
class="nav-group-trigger-icon"
[attr.direction]="expanded ? 'down' : 'right'"
[attr.title]="expanded ? commonStrings.keys.collapse : commonStrings.keys.expand"
>
The text was updated successfully, but these errors were encountered: