Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove datepickerToggle fallback common string property #445

Merged
merged 1 commit into from Jan 10, 2023

Conversation

kevinbuhmann
Copy link
Member

PR Checklist

PR Type

Remove unnecessary code.

What is the current behavior?

The datepickerToggle exists and is only used as a fallback.

What is the new behavior?

The datepickerToggleChooseDateLabel and datepickerToggleChangeDateLabel strings should be used instead.

Does this PR introduce a breaking change?

Yes. The datepickerToggle common string property was removed. Use datepickerToggleChooseDateLabel and datepickerToggleChangeDateLabel instead.

BREAKING CHANGE: The `datepickerToggle` common string property was
removed. Use `datepickerToggleChooseDateLabel` and `datepickerToggleChangeDateLabel`
instead.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann merged commit 2d2c6ea into beta Jan 10, 2023
@kevinbuhmann kevinbuhmann deleted the kevin/breaking/datepicker-toggle-string branch January 10, 2023 15:58
@github-actions
Copy link
Contributor

🎉 This PR is included in version 15.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants