fix(tree-view): associate tree node content with checkbox as label #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are not `.label` elements in `.clr-treenode-content`.
This change allows clicking the tree node content to select/deselect the tree node. The code initializes `this._model.textContent` had to be moved to after view init because the DOM element's text content wasn't available in after content init after the DOM structure changes. VPAT-791 BREAKING CHANGE: The internal DOM structure of the tree node component has been changed. The `.clr-treenode-content` element is no longer rendered for selectable tree nodes; instead, the tree node content is rendered inside the checkbox's label element.
Thank you, 🤖 Clarity Release Bot |
Jinnie
approved these changes
Jan 10, 2023
|
🎉 This PR is included in version 15.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Bugfix
What is the current behavior?
The tree node content is not a label for the checkbox; therefore, it is not included in the checkbox's click target.
Issue Number: VPAT-791
What is the new behavior?
The tree node content is rendered in the checkbox's label; therefore, it is included in the checkbox's click target.
Does this PR introduce a breaking change?
Technically, yes. The internal DOM structure of the tree node component has been changed. The
.clr-treenode-contentelement is no longer rendered for selectable tree nodes; instead, the tree node content is rendered inside the checkbox's label element.