Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): keep tooltip content visible as user hovers #447

Merged
merged 4 commits into from Jan 10, 2023

Conversation

kevinbuhmann
Copy link
Member

PR Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

The tooltip content was hidden as soon as the user moused out of the trigger.

Issue Number: VPAT-617

What is the new behavior?

The tooltip content will stay visible if the user mouses from the trigger into the content. To support this, the tooltip content has an expanded hover target provided by the ::after pseudo element.

Does this PR introduce a breaking change?

No.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Previously, the tooltip content was hidden as soon as the user moused
out of the trigger.

Now, the tooltip content will stay visible if the user mouses from the
trigger into the content. To support this, the tooltip content has an
expanded hover target provided by the `::after` pseudo element.

VPAT-617
@@ -110,6 +110,15 @@
transition: opacity 0.3s linear;
white-space: normal;
z-index: map-get($clr-layers, tooltips);

&::after {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution, thanks!

@kevinbuhmann kevinbuhmann merged commit 9938c1e into main Jan 10, 2023
@kevinbuhmann kevinbuhmann deleted the kevin/tooltip-hover branch January 10, 2023 15:46
@kevinbuhmann
Copy link
Member Author

This was released in 13.11.12.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
@kevinbuhmann kevinbuhmann removed the a11y label Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants