Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: python.md #108

Closed
Trippy3 opened this issue Mar 13, 2023 · 2 comments
Closed

typo: python.md #108

Trippy3 opened this issue Mar 13, 2023 · 2 comments
Assignees
Labels
📝 documentation Improvements or additions to documentation
Milestone

Comments

@Trippy3
Copy link

Trippy3 commented Mar 13, 2023

Describe the bug

## Dynamic routes
You can define [dynamic routes by adding route parameters to your worker files](../features/dynamic-routes.md) (like `[id].py`). To read them in Ruby, access to the `request.params` object:

In python.md, it says To read them in Ruby," but shouldn't this be "To read them in Python, ?
It's a very small thing, but I noticed it, so I opened an issue.

Reproduction steps

N/A

Expected behavior

The text in python.md above will be modified.

Additional context

No response

@Angelmmiguel Angelmmiguel added the 📝 documentation Improvements or additions to documentation label Mar 14, 2023
@Angelmmiguel
Copy link
Contributor

Hello @Trippy3,

Thank you for the report! AS you noticed, that's a typo error on the documentation. I will fix it 😄

@Angelmmiguel Angelmmiguel added this to the v1.1.0 milestone Mar 14, 2023
@Angelmmiguel
Copy link
Contributor

Done! Closed by b884f96 😄

@Angelmmiguel Angelmmiguel self-assigned this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants