Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.trace is missing in the JS kit #248

Closed
Angelmmiguel opened this issue Oct 20, 2023 · 0 comments · Fixed by #249
Closed

console.trace is missing in the JS kit #248

Angelmmiguel opened this issue Oct 20, 2023 · 0 comments · Fixed by #249
Assignees
Labels
🐛 bug Something isn't working 🔨 sdks Issues related to language SDKs
Milestone

Comments

@Angelmmiguel
Copy link
Contributor

Describe the bug

The console.trace method is used by frameworks like HonoJS to provide extra information when capturing errors. This method is not present in the current SDK and is causing the framework to fail.

Reproduction steps

  1. Clone the project and go to the examples/js-hono folder
  2. Edit the src/index.js file and add a throw new Error("error!")` to any handler
  3. Run the example and access to the handler

Expected behavior

Instead of a generic error by wws, Hono should manage it and provide the error. Currently, it's failing because it tries to call console.trace.

Additional context

No response

@Angelmmiguel Angelmmiguel added 🐛 bug Something isn't working 🔨 sdks Issues related to language SDKs labels Oct 20, 2023
@Angelmmiguel Angelmmiguel added this to the 1.7.0 milestone Oct 20, 2023
@Angelmmiguel Angelmmiguel self-assigned this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🔨 sdks Issues related to language SDKs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant