Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GRE and STT tunnels #229

Merged
merged 1 commit into from Dec 17, 2019
Merged

Add support for GRE and STT tunnels #229

merged 1 commit into from Dec 17, 2019

Conversation

jianjuns
Copy link
Contributor

Reasons to add GRE and STT support:

  1. There is no harm to support more options.
  2. So far with my tests IPSec works only for GRE (it could be due to OVS or module versions, and I am still debugging).
  3. STT has best performance when NIC does not support offloading with encapsulation.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests. This command can only be run by members of the vmware-tanzu organization
  • /skip-e2e: to skip e2e tests. This command can only be run by members of the vmware-tanzu organization

tnqn
tnqn previously approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Dec 16, 2019

/test-e2e

antoninbas
antoninbas previously approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianjuns
Copy link
Contributor Author

/recheck

@jianjuns
Copy link
Contributor Author

/test-e2e

@jianjuns jianjuns dismissed stale reviews from antoninbas and tnqn via 36d866c December 16, 2019 21:05
@jianjuns
Copy link
Contributor Author

/test-e2e

antoninbas
antoninbas approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again for merge

@jianjuns jianjuns merged commit 03f875e into master Dec 17, 2019
@jianjuns jianjuns deleted the ovs-tunnel branch December 17, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@tnqn tnqn tnqn left review comments

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jianjuns @antrea-bot @tnqn @antoninbas @vmwclabot