-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable users to specify default flag values for the apps plugin via environment variables #114
Comments
@heyjcollins is there prior art for this approach that you think is particularly well done?
|
Thanks for the feedback and suggestions @scothis. Originally, the plan was to provide a new (for apps plugin) Upon further consideration, we've decided to pursue only the config solution. Why
So...For the time being, and until/unless we get user feedback indicating the need for the alternative env var solution, we're going to implement (#108). Your suggestions/questions here contributed to this decision and will inform our work on #108 so thank you very much. |
Because we haven't established common pattern for persisting configuration across all plugins and tanzu CLI versions, we've decided to put #108 on hold 'till we've aligned on an approach. |
@heyjcollins Values from env var can contain sensitive data and should not output as plain text. Workload diff seems sufficient to me and would vote to drop this section from the output. |
This is a good point. |
Decisions:
|
Any value written to a K8s resource (that is not a Values from |
There are some nuanced scenarios whereby the We've decided to remove the support for I've updated the original issue description and added |
Description of problem
Developers will provide the same flags/values repeatedly when iterating on their application code.
Typing or copy/pasting the flag values for every
workload create/update/apply
adds friction to the developer workflow.We should make it possible for the user to specify sane defaults via envvars such that they can execute their commands with the minimum required flags
Related to #108
Proposed solution
Precedence order: flag/value > environment variable > config value [*1]
[1] if/when we work on #108 (enabling users to configure persistent flag values...) --- the EnvVar should take precedence over the configured value for a given flag
Command output changes:
Output from
tanzu apps workload create/update/apply
should remain as-is (no changes are required to support this new feature).naming convention for the env vars:
-debugTANZU_APPS_DEBUG--fileTANZU_APPS_FILE--git-repoTANZU_APPS_GIT_REPO-live-updateTANZU_APPS_LIVE_UPDATE--local-pathTANZU_APPS_LOCAL_PATH--namespaceTANZU_APPS_NAMESPACE--source-imageTANZU_APPS_SOURCE_IMAGE--sub-pathTANZU_APPS_SUB_PATHstrikethroughitems have been removed from initial scope for this feature. We'll re-evaluate post feature release to determine what additional envvar/flags would be valuable to support.Describe alternatives you've considered
use only configurable values
The text was updated successfully, but these errors were encountered: