-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags to support --local-path workflow that allows user to override registry opts defaults #116
Comments
@danfein ^^ |
We will also need support for |
@danfein Can we get Design recco for a CA Certs Path flag that can be used multiple times? |
Recommendation
Thinking
Also considered
|
Recommended flags for additional registry configuration
|
Description of problem
Multiple instances were reported where a corporate firewall scrambles the SSL handshake between a dev's local machine and the external signed registry like azurecr.io. This results in apps plugin failing to push an image and an error message
certificate signed by unknown authority
.Proposed solution
Currently
apps
plugin does not support flags to set theCACertPaths
,VerifyCerts
andInsecure
registry options through flags and VerifyCerts defaults totrue
. We should add flags to support booleanVerifyCerts
andInsecure
options, and default to secure options, but allow the user to override it using flags if they are behind firewall and run into this issue.For Future state, we should provide a
config
option (once #108 is implemented) to let user change the defaults to insecure mode as they will always hit this firewall issue, but won't have to provide flags all the time.CC @danfein @heyjcollins for design and product input regarding flag names.
Thanks to @cpage-pivotal for bringing this to our attention.
Updates
We have decided to not implement support for overriding the following options
insecure
(will always default to false)verifyCerts
(will always default to true)Flags that will be added as part of this issue to support passing the following information
username
password
token
caCertsPath
Reference: https://pkg.go.dev/github.com/vmware-tanzu/carvel-imgpkg@v0.29.0/pkg/imgpkg/registry#Opts
The text was updated successfully, but these errors were encountered: