Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tanzuignore supports regex #132

Closed
heyjcollins opened this issue May 23, 2022 · 2 comments
Closed

.tanzuignore supports regex #132

heyjcollins opened this issue May 23, 2022 · 2 comments

Comments

@heyjcollins
Copy link
Contributor

Description of problem

Extend the work done in #33 to support regex.

PM to complete

Proposed solution

<Please describe your proposed solution, preferably in the following style:>

Given <Some Condition>
When <Something Happens>
Then <This other thing should happen?>

Example

<Code snippets that illustrate the when/then blocks>

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@scothis
Copy link
Contributor

scothis commented May 26, 2022

Please don't define a new syntax for the .tanzuignore file, use the existing syntax that is common with .gitignore, .dockerignore etc. If a user has an existing ignore file that is appropriate, they could use that file by --ignore-file .dockerignore while the default value for --ignore-file would be .tanzuignore

@atmandhol atmandhol modified the milestones: 0.8.0, 0.9.0 Jun 13, 2022
@heyjcollins heyjcollins removed this from the 0.9.0 milestone Jun 15, 2022
@heyjcollins
Copy link
Contributor Author

heyjcollins commented May 18, 2023

Going to close this issue as we haven't received any votes or feedback requesting this feature be added.
Feel free to reopen with comment if this is an enhancement you're interested in.

@atmandhol atmandhol changed the title .tanzuignore supports regex -- placeholder .tanzuignore supports regex Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants