Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User must provide either --git-branch or --git-tag when creating a workload using --git-commit flag #28

Closed
heyjcollins opened this issue Mar 17, 2022 · 0 comments · Fixed by #423
Assignees
Labels
accepted enhancement New feature or request
Milestone

Comments

@heyjcollins
Copy link
Contributor

Description of problem

While researching an issue whereby a user is required to provide --git-branch in addition to --git-tag in order for workload create/update/apply to succeed, found out user has to provide either --git-tag, --git-branch or both if they want want to provide --git-commit in order to create the workload from a specific commit.
Yet, this issue is blocked by the usage of the current version of FluxCD Source Controller (0.16) in Tanzu Application Platform

Proposed solution

  1. Update the version of FluxCD
  2. Remove client-side validation for mutual inclusion of (--git-branch or --git-tag) when --git-commit is provided

Additional context

Issue originally submitted by @warango4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants