Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapp rename should support optional --new-namespace #165

Closed
cppforlife opened this issue Nov 19, 2020 · 5 comments · Fixed by #294
Closed

kapp rename should support optional --new-namespace #165

cppforlife opened this issue Nov 19, 2020 · 5 comments · Fixed by #294
Assignees
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@cppforlife
Copy link
Contributor

this would help scenarios where state configmap was dropped into a wrong namespace.

@cppforlife cppforlife added the enhancement This issue is a feature request label Nov 19, 2020
@cari-lynn cari-lynn added the carvel accepted This issue should be considered for future work and that the triage process has been completed label Jan 28, 2021
@iamhsk
Copy link
Contributor

iamhsk commented May 7, 2021

@cppforlife Is the intent behind this issue to move both the renamed app and the configmap to a different namespace? Or just the configmap? And in what situation a configmap would be dropped into a wrong namespace?

@renuy
Copy link
Contributor

renuy commented Aug 19, 2021

Only, the state configmap should be renamed. Label stays the same. Everything inside the configMap should remain the same.

@renuy
Copy link
Contributor

renuy commented Aug 26, 2021

@cppforlife , how should the behaviour be for following commands

  1. kapp rename -a app --new-name
    --is this a valid case? currently we do not validate presence of name parameter, but error out anyways later on. should we mandate the presence of new-name?
  2. kapp rename -a app --new-name app1
    --this is normal use case. no issues here.
  3. kapp rename -a app --new-name app1 --new-namespace newNS
    --change the name as well as namespace. again this is the new normal use case.
  4. kapp rename -a app --new-namespace newNS
    -- how should this be treated? Is this valid use case? This will not change the name, only create it in the new namespace
  5. Does namespace change also apply to labeled apps? or only recorded apps
  6. if the new-namespace does not exist, should it be created? or error out?

my views:

  • if new-name and new-namespace, both are not provided then error out.
  • if new-namespace does not exist, then error out. (do not create it) (are we in the business of creating namespace?)
  • if new-name is not provided and only new-namespace is provided, then this is request to update the namespace. so go ahead and do it.

@renuy renuy linked a pull request Aug 26, 2021 that will close this issue
@renuy renuy self-assigned this Aug 30, 2021
@renuy
Copy link
Contributor

renuy commented Aug 30, 2021

few more things,

  1. How should the history be treated for renaming?
  2. should the history be also moved across namespace, if namespace is changed?

@renuy
Copy link
Contributor

renuy commented Sep 23, 2021

available in release v0.40.0

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Sep 23, 2021
@aaronshurley aaronshurley removed the carvel triage This issue has not yet been reviewed for validity label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants