support filtering resources by label in kapp deploy

[jdef]

What steps did you take:

:; kapp deploy -a 'label:!undefined' -f path/to/yaml

What happened:

kapp: Error: Expected label selector to check for equality

What did you expect:
I expected kapp to deploy all the resources in the yaml since none have a label w/ the key "undefined", and the expression in the attempted command line is supposed to be valid.

Anything else you would like to add:
[Additional information that will assist in solving the issue.]

Environment:

• kapp version (use kapp --version): 0.37.0
• OS (e.g. from /etc/os-release):
• Kubernetes version (use kubectl version)

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

[cppforlife]

@jdef -a label:... is not used to filter resources within given yaml. for deploy command it's used to determine what label to apply (add) to resources that will be deployed. (e.g. -a label:foo=bar will result in foo label being set on all created/updated resources). for inspect command -a label:... is used to determine what resources to select from the cluster. same goes for delete command.

it sounds like you want to filter resources for the deploy operation. we have --filter-* flags; however, we do not currently have a flag that filter by label. would be good to add it though.

[jdef]

Thanks for clarifying

…

On Fri, Aug 13, 2021, 10:51 PM Dmitriy Kalinin ***@***.***> wrote: @jdef <https://github.com/jdef> -a label:... is not used to filter resources within given yaml. for deploy command it's used to determine what label to apply to resources that are deployed. (e.g. -a label:foo=bar will result in foo label being set on all deployed resources). for inspect command -a label:... is used to determine what resources to select from the cluster. same goes for delete command. it sounds like you want to filter resources for the deploy operation. we have --filter-* flags; however, we do not currently have a flag that filter by label. would be good to add it though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLDAIXC2P5KWCIOBS2DT4XK3VANCNFSM5CCLQWEA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[cppforlife]

per similar design, in a slightly different enhancement [0], we should probably introduce --filter '{"resource": {"labelSelector": "x=y"}}' (this builds on our existing way of specifying filters). additionally for as a convenience we could add a sugar flag: --filter-labels 'x=y'. in both cases full label selector syntax should be accepted.

/cc @renuy

[0] #182 (comment)

[renuy]

Summarising: Introduction of a new resource filter flag (--filter-labels). This would be applicable for the following kapp commands:

• deploy
• delete
• inspect
• app-group deploy
• tools inspect

[renuy]

@jdef , adding this issue to the backlog. It is currently not prioritised.
However, we could prioritise a review, if you want to put together a pull request for this.

[jdef]

I'm still waiting for corporate approval on other OSS patches I submitted for review, internally, *last year*. So while I'd like to be able to push a PR for this, my hands are tied for now.

…

On Tue, Aug 17, 2021 at 12:09 PM Renu Yarday ***@***.***> wrote: @jdef <https://github.com/jdef> , adding this issue to the backlog. It is currently not prioritised. However, we could prioritise a review, if you want to put together a pull request for this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5KLEZHLWRDPCUIXZOA5DT5KCVDANCNFSM5CCLQWEA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- James DeFelice 585.241.9488 (voice) 650.649.6071 (fax)

[renuy]

Will be available in release v0.40.0

[renuy]

release v0.40.0