Add example of adding a map to an array in a complex object #236
Conversation
|
@amalagaura Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@amalagaura Thank you for signing the Contributor License Agreement! |
amalagaura
force-pushed
the
223_document_array_of_maps
branch
from
ed47f37
to
c5d559f
Compare
|
@pivotal-dean I added the overlay example from #223. I hope it is sufficient. |
examples/playground/overlays/example-append-map-to-array/_data.yml
Outdated
Show resolved
Hide resolved
| @@ -75,6 +75,7 @@ exampleSets = [ | |||
| {"id": "example-edit-map-value"}, | |||
| {"id": "example-remove-map-item"}, | |||
| {"id": "example-rename-key-in-map"}, | |||
| {"id": "example-append-map-to-array"}, | |||
There was a problem hiding this comment.
This example may follow logically after Append array item, how would you feel about this example being number 11?
examples/playground/overlays/example-append-map-to-array/append-map-to-array.yml
Outdated
Show resolved
Hide resolved
amalagaura
force-pushed
the
223_document_array_of_maps
branch
from
5b0eb54
to
e0e4054
Compare
|
@StevenLocke Thanks for the feedback. I liked your suggestions and simplified accordingly, hope it is better. I left an id field, maybe it is not needed and we can simplify the map further, I am not sure.. I put the order of the example according to what @pivotal-dean suggested in issue #223. I think after |
|
Looks great. Thanks for the addition @amalagaura ! |
Follow up from issue #223 to document the example/answer given