Make overlay error order deterministic #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when ytt overlay hit an error, the error line orders are not deterministic. However many CI systems could make assumptions on the order of the error messages in test cases. Now sort the lines in alphabetical order to make it deterministic. Signed-off-by: Hanlin Shi <shihanlin9@gmail.com>
|
cc @StevenLocke, PTAL. |
|
Accepting PR as a fix for the determinism until upstream source is identified and addressed. |
|
@hanlins, VMware has approved your signed contributor license agreement. |
github-actions
bot
added
the
carvel triage
aaronshurley
removed
the
carvel triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when ytt overlay hit an error, the error line orders are not deterministic. However many CI systems could make assumptions on the order of the error messages in test cases. Now sort the lines in alphabetical order to make it deterministic.