Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Release Targets #180

Closed
4 tasks done
anusha94 opened this issue Oct 28, 2021 · 6 comments
Closed
4 tasks done

Create Release Targets #180

anusha94 opened this issue Oct 28, 2021 · 6 comments
Assignees
Labels
area/release help wanted Extra attention is needed
Projects
Milestone

Comments

@anusha94
Copy link
Contributor

anusha94 commented Oct 28, 2021

Create make targets that will be used for release activities

  • host-agent-binary
  • infrastructure-components.yaml
  • cluster-template.yaml
  • metadata.yaml
  • [ ] byoh controller image (build and push)
  • [ ] imgpkg k8s bundle (build and push)
@anusha94 anusha94 self-assigned this Oct 28, 2021
@anusha94 anusha94 assigned anusha94 and unassigned anusha94 Nov 15, 2021
@anusha94 anusha94 added the help wanted Extra attention is needed label Nov 15, 2021
@jamiemonserrate jamiemonserrate added this to the v0.1.1 milestone Nov 26, 2021
@jamiemonserrate jamiemonserrate added this to To do in v0.1.1 via automation Nov 26, 2021
@jamiemonserrate
Copy link
Contributor

Can we ensure that when we publish the host-agent binary, it is an executable binary? (that is the exec bit is set)

@anusha94
Copy link
Contributor Author

anusha94 commented Jan 11, 2022

/unassign

@anusha94 anusha94 removed their assignment Jan 24, 2022
@anusha94
Copy link
Contributor Author

fyi - I am working on build and push controller image task

@anusha94 anusha94 self-assigned this Jan 24, 2022
@anusha94
Copy link
Contributor Author

In BYOH, currently all images and installer bundles are pushed to Harbor registry. To push to this registry, we need to be in VMware's corporate network. Automating the push via GitHub Action's runner may become complicated as we will have to directly hit the registry's IP and store this IP as a secret.
We will migrate to k-sigs soon and hope to leverage Prow's capability to push to gcr.io just like other providers. Closing this issue for now.

@anusha94
Copy link
Contributor Author

Can we ensure that when we publish the host-agent binary, it is an executable binary? (that is the exec bit is set)

@jamiemonserrate when we build the binary, it is indeed executable. But when we download the binary, the exec bit is not set. Same goes for any other binary we download. See clusterctl install or kubectl install

TIL - https://unix.stackexchange.com/questions/82578/why-is-that-when-i-download-a-binary-from-the-web-it-doesnt-have-executable-per

Let me know if you had something else to try out. Otherwise, we are pretty much done with this issue.

@jamiemonserrate
Copy link
Contributor

That makes sense. Not sure what I was thinking when I wrote

Can we ensure that when we publish the host-agent binary, it is an executable binary? (that is the exec bit is set).

Fair enough.

@anusha94 anusha94 closed this as completed Feb 1, 2022
v0.1.1 automation moved this from To do to Done Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release help wanted Extra attention is needed
Projects
Development

Successfully merging a pull request may close this issue.

2 participants