Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Version drop down does not change selected version #3771

Closed
stmcginnis opened this issue Mar 29, 2022 · 5 comments
Closed

Version drop down does not change selected version #3771

stmcginnis opened this issue Mar 29, 2022 · 5 comments
Assignees
Labels
kind/docs A change in documentation
Projects
Milestone

Comments

@stmcginnis
Copy link
Contributor

Description

When looking at the docs, I tried to select a different version to compare the last release with the current release. I am able to click on the drop down and select the other version, but the page refreshes and brings me back to where I was.

If I manually edit the version string in the URL, that does switch me over to the right version of the docs. But again on the other version, if I try to use the drop down to select the other one to go back, I am now stuck on the version I entered in the URL.

Location

All docs pages, as far as I can tell.

Additional Context

@stmcginnis stmcginnis added the kind/docs A change in documentation label Mar 29, 2022
@stmcginnis stmcginnis added this to the v0.11.0 milestone Mar 29, 2022
@stmcginnis stmcginnis added this to To do in v0.11.0 via automation Mar 29, 2022
@stmcginnis
Copy link
Contributor Author

Initially saw this on macOS using Brave. Also observed the behavior using Safari.

@jpmcb
Copy link
Contributor

jpmcb commented Mar 29, 2022

I'm seeing the same behavior:

drop-down-no-work

System:

  • Firefox developer edition 97.0 (64 bit version)
  • Pop OS 21.04

@jpmcb
Copy link
Contributor

jpmcb commented Mar 29, 2022

Seeing the same behavior on Chrome:

chrome-versioned-not-working

Version 98.0.4758.102 (Official Build) (64-bit)

@joshrosso joshrosso moved this from To do to In progress in v0.11.0 Mar 29, 2022
@joshrosso joshrosso removed this from In progress in v0.11.0 Mar 29, 2022
@joshrosso joshrosso added this to To do in v0.12.0 via automation Mar 29, 2022
@joshrosso joshrosso modified the milestones: v0.11.0, v0.12.0 Mar 29, 2022
@joshrosso joshrosso moved this from To do to Todo: Docs in v0.12.0 Mar 30, 2022
@joshrosso
Copy link
Contributor

@stmcginnis @jpmcb was the PR we approved at #3871 in relation to this issue?

If so, can we attach it and close this one. Thanks!

@stmcginnis
Copy link
Contributor Author

Yep, that was the fix. It should be working now.

v0.12.0 automation moved this from Todo: Docs to Done Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/docs A change in documentation
Projects
No open projects
Development

No branches or pull requests

4 participants