Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move app repo sync to run in repo namespace (and cluster) #1647

Closed
absoludity opened this issue Apr 8, 2020 · 3 comments
Closed

Move app repo sync to run in repo namespace (and cluster) #1647

absoludity opened this issue Apr 8, 2020 · 3 comments
Labels
component/apprepository Issue related to kubeapps apprepository kind/proposal An issue that reports a new feature proposal to be discussed
Projects

Comments

@absoludity
Copy link
Contributor

Currently, when creating an AppRepository, if the app repo namespace isn't kubeapps (ie. this is a per-namespace AppRepository), for a private repo we save a copy of the repository secret in kubeapps own namespace using the service account clientset. This enables the existing assetsync service to be able to sync private AppRepositories in other namespaces.

It is not ideal and is a temporary work-around until the asset-sync is updated to run cronjobs in other namespaces with the assetsvc receiving the data. See the relevant section of the design doc for details.

This issue is a placeholder to refer to in code, to ensure that we move the sync job to the user namespace (and send data from there to the assetsvc) and remove the code creating the copy.

@stale
Copy link

stale bot commented Oct 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 2, 2020
@stale stale bot removed the wontfix label Oct 2, 2020
@absoludity absoludity added kind/feature An issue that reports a feature (approved) to be implemented and removed kind/enhancement An issue that reports an enhancement for an implemented feature labels May 10, 2021
@ppbaena ppbaena removed the pinned label May 13, 2021
@ppbaena ppbaena added the component/apprepository Issue related to kubeapps apprepository label May 24, 2021
@absoludity absoludity changed the title Move app repo sync to run in repo namespace Move app repo sync to run in repo namespace (and cluster) Sep 13, 2021
@ppbaena ppbaena added this to the App repository refactor milestone Sep 24, 2021
@dlaloue-vmware
Copy link
Collaborator

Currently, private app repositories can only be managed via UI, and cannot be managed via kubectl for the following reasons:

  • updating the secret in the namespace does not update the copy
  • deleting the repository (e.g. deleting the namesapce) does not delete the copy of the secret

@ppbaena ppbaena added kind/proposal An issue that reports a new feature proposal to be discussed and removed kind/feature An issue that reports a feature (approved) to be implemented labels Jun 9, 2022
@ppbaena
Copy link
Collaborator

ppbaena commented Jun 9, 2022

To be closed as it is not considered in the current roadmap for Kubeapps, and it's a long time since it was requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/apprepository Issue related to kubeapps apprepository kind/proposal An issue that reports a new feature proposal to be discussed
Projects
Archived in project
Kubeapps
  
Backlog
Development

No branches or pull requests

5 participants