Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check old frontend deps #3480

Closed
11 tasks done
antgamdia opened this issue Sep 22, 2021 · 1 comment
Closed
11 tasks done

Check old frontend deps #3480

antgamdia opened this issue Sep 22, 2021 · 1 comment
Assignees
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature
Projects

Comments

@antgamdia
Copy link
Contributor

antgamdia commented Sep 22, 2021

While upgrading our frontend deps I've noticed there are several not being upgraded in quite a long time.
Perhaps they are deprecated or have been replaced by new ones, so they stopped publishing under this npm module nada.

In a preliminary selection of those whose latest release date is 1y ahead, I've extracted:

More than a year

  • fstream 🔴
  • jsonwebtoken 🟢
    • Action: continue using it.
    • Explanation: not recently updated, but it is still useful for validating our jwt tokens
  • normalize.css 🟡
  • prop-types 🟢
    • Action: continue using it.
    • Explanation: it is for checking the type of the React props and similar objects. Not frequently updated, but still useful.
  • raf 🔴
    • Action: delete dep
    • Explanation: it was introduced during the initial version of our enzyme tests (7e02104). I guess now Enzyme itself has support for requestAnimationFrame and this dep is no longer required.
    • Tracked at: Remove raf UI dependency #3523
  • redux-thunk 🟢
    • Action: continue using it.
    • Explanation: no activity for 3 years, but it is part of redux and it is a way to define action creators (like redux saga or redux loop, I think). We are actively using it, so let's keep it.
  • seamless-immutable 🔴

Under a year

  • react-diff-viewer 🟡
    • Action: continue using it, but stay vigilant since it seems to be unmaintained.
    • Explanation: no new release has been published so far, some users have reported some failures with the latest React versions. However, it is a "core" dep, as it provides the diff between two text files. Idea: what if we migrate from Ace two Monaco (the vscode text editor), which also have diff views.
  • react-helmet 🟢
    • Action: continue using it
    • Explanation: no new release has been published so far, but it is a rather simple dependency (adding headers) and we do use it for hot-reloading the dark mode.
  • react-jsonschema-form: 🔴
  • typesafe-actions 🟢
    • Action: continue using it.
    • Explanation: no new release has been published so far, but it is a utility (with no deps) for simplifying the process of creating a redux action. In fact, it was updated and we are still using the old and deprecated syntax.

Perhaps some of them are so simple that they don't require any frequent upgrade, but I think it worths having a look at each of them.

@antgamdia antgamdia added component/ui Issue related to kubeapps UI priority/low kind/enhancement An issue that reports an enhancement for an implemented feature labels Sep 22, 2021
@antgamdia antgamdia self-assigned this Sep 22, 2021
@project-bot project-bot bot added this to Inbox in Kubeapps Sep 22, 2021
@antgamdia antgamdia moved this from Inbox to Backlog in Kubeapps Sep 24, 2021
@antgamdia antgamdia moved this from Backlog to Next iteration discussion in Kubeapps Sep 24, 2021
@ppbaena ppbaena moved this from Next iteration discussion to Committed in Kubeapps Sep 27, 2021
@antgamdia antgamdia moved this from Committed to In progress in Kubeapps Sep 29, 2021
@antgamdia antgamdia moved this from In progress to Waiting For Review in Kubeapps Sep 29, 2021
@antgamdia
Copy link
Contributor Author

Closing as all the PRs have been merged.

Kubeapps automation moved this from Waiting For Review to Done Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
No open projects
Kubeapps
  
Done
Development

No branches or pull requests

2 participants