Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing resources #632

Closed
stormmore opened this issue Sep 13, 2018 · 2 comments
Closed

Missing resources #632

stormmore opened this issue Sep 13, 2018 · 2 comments
Assignees
Labels
awaiting-more-evidence Need more info to actually get it done. component/ui Issue related to kubeapps UI

Comments

@stormmore
Copy link

stormmore commented Sep 13, 2018

So during developing a chart and testing deploys I have gotten into a situation where Kubeapps doesn't display any of the resource:

image

I suspect I am doing something stupid with labels but not 100% sure.

Here is the chart:

gitea-0.2.0.tar.gz

It happens even with the default values.

Here is my helm version:

Client: &version.Version{SemVer:"v2.10.0", GitCommit:"9ad53aac42165a5fadc6c87be0dea6b115f93090", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.10.0", GitCommit:"9ad53aac42165a5fadc6c87be0dea6b115f93090", GitTreeState:"clean"}
@migmartri migmartri added component/ui Issue related to kubeapps UI kind/bug An issue that reports a defect in an existing feature priority/important-soon labels Sep 13, 2018
@migmartri migmartri added this to Backlog in Kubeapps via automation Sep 13, 2018
@migmartri migmartri moved this from Backlog to Committed in Kubeapps Sep 13, 2018
@migmartri migmartri added awaiting-more-evidence Need more info to actually get it done. and removed priority/important-soon labels Sep 13, 2018
@migmartri migmartri removed this from Committed in Kubeapps Sep 13, 2018
@migmartri migmartri removed the kind/bug An issue that reports a defect in an existing feature label Sep 13, 2018
@migmartri migmartri self-assigned this Sep 13, 2018
@migmartri
Copy link
Contributor

migmartri commented Sep 13, 2018

I've been looking into this and this is what've found:

TLDR; The deployment has a duplicated chart label:

Root cause

The app is actually crashing complaining about a duplicated key.

selection_703

Looking into the tags in the rendered template I noticed that it was the deployment the one that had duplicated labels.

helm get manifest miguel-test-git | grep   'chart: "gitea-0.2.0"' -C 5

kind: Deployment
metadata:
  name: miguel-test-git-gitea
  labels:
    app: gitea
    chart: "gitea-0.2.0"
    heritage: "Tiller"
    release: "miguel-test-git"
    chart: "gitea-0.2.0"

and indeed the chart template includes the duplicated template

metadata:
  name: {{ include "gitea.fullname" . }}
  labels:
    app: {{ include "gitea.name" . }}
    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
    heritage: "{{ .Release.Service }}"
    release: "{{ .Release.Name }}"
    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"

Removing the duplicating key and upgrading the release fixed the issue:

selection_704

Action items

  • Our error handling here seems deficient and misleading, we need to improve it. Error handling on release/view page #635
  • About this specific case, apparently helm is OK with this duplication issue so we might also want to relax this rule a little bit. I am not convinced about this though as long as we show the user enough info about what happened by implementing the first point. Relax yaml parsing in releases/view page #636
  • Potentially the helm linter should detect this issue
$ helm lint .
==> Linting .
Lint OK

@migmartri
Copy link
Contributor

@stormmore I have created two follow up tasks related to the action items, so if you do not mind I am going to go ahead and close this issue. Let me know if you want to keep it open for any reason.

Thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-more-evidence Need more info to actually get it done. component/ui Issue related to kubeapps UI
Projects
None yet
Development

No branches or pull requests

2 participants