This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Use custom scrollbars for content, summary, and quick switcher #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 13, 2020 18:00
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
GuessWhoSamFoo
force-pushed
the
scrollbars
branch
from
82ef71f
to
9490113
Compare
wwitzel3
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom scrollbars can avoid situations where the application looks differently across systems. This PR adds a custom scrollbar for a few components as adding them to nested components (datagrids, terminal) would be trickier.
Other libraries such as simplebar and ngx-scrollbar were considered, but they had weird interactions with CSS/flexbox or strange ways to capture scroll events.
Old:
New:
