Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Migrate to node 16 and npm 7 #2505

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

GuessWhoSamFoo
Copy link
Contributor

@GuessWhoSamFoo GuessWhoSamFoo commented May 28, 2021

What this PR does / why we need it:
https://github.com/npm/cli/wiki/%22cb()-never-called%3F--I'm-having-the-same-problem!%22

Since all npm commands in github actions use npm ci, the lockfile will still be expected to be generated via node < 16 but will use the newer version at runtime.

  • Separated electron asset building steps in build.go
  • Some dependencies had to be bumped due to new peer dependency requirements
  • Bumping to node 16 (which eventually will become LTS in October) implicitly moves to npm 7
  • marked had to be removed from resolutions. xref: [BUG] Dependency Update- Security compodoc/compodoc#1033

Which issue(s) this PR fixes

@GuessWhoSamFoo GuessWhoSamFoo force-pushed the node-16 branch 2 times, most recently from fdce835 to a07c404 Compare May 28, 2021 22:08
@GuessWhoSamFoo GuessWhoSamFoo marked this pull request as ready for review May 28, 2021 22:34
@GuessWhoSamFoo
Copy link
Contributor Author

GuessWhoSamFoo commented May 28, 2021

@mklanjsek Passing 6/6 in a row (technically 18 b/c of build matrix). Am I missing anything here?

@mklanjsek
Copy link
Contributor

@GuessWhoSamFoo Storybook does not run locally for me, empty screen and errors in console:

Screen Shot 2021-06-01 at 12 13 00 PM

Signed-off-by: Sam Foo <foos@vmware.com>
@GuessWhoSamFoo
Copy link
Contributor Author

Not sure what react-docgen and react-is are for as https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#react-peer-dependencies only states that react and react-dom are required peer dependencies.

The above error requires react and react-dom to have matching versions.

Also expected to close #2524

@mklanjsek
Copy link
Contributor

Storybook is running nicely now. I had some issues running tests, but these were resolved with help from @GuessWhoSamFoo

As for react-docgen and react-is - I think they were used to generate args table in storybook docs pane. However it looks like that was broken since upgrade to latest format (at least it's broken on reference.octant.dev):

<ArgsTable story = "story name" />

So in regards to node/npm upgrade, I think this ready to go, storybook docs issues could be addressed in different PR.

@GuessWhoSamFoo GuessWhoSamFoo merged commit 9d9c924 into vmware-archive:master Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm ERR! cb() never called!
3 participants